refactor(tree): add raf check for tree SSR #16102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayaKirova
requested changes
Aug 21, 2025
| private selectionService: IgxTreeSelectionService, | ||
| private treeService: IgxTreeService, | ||
| private element: ElementRef<HTMLElement>, | ||
| private platform: PlatformUtil |
Contributor
There was a problem hiding this comment.
There are some failing tests due to the constructor changes. Those should be fixed.
Contributor
Author
There was a problem hiding this comment.
fixed the tests by adding the extra parameter.
| requestAnimationFrame(() => { | ||
| this.selectionService.selectNodesWithNoEvent(toBeSelected); | ||
| }); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Is it needed to set the selection on the server? I assume that when the view hydrates it would go through the same logic and apply selection if needed, so maybe the else handling here is redundant.
Contributor
Author
There was a problem hiding this comment.
Yes, removed the else
Contributor
There was a problem hiding this comment.
The else is still here. It got added back with your last commit.
tishko0
force-pushed
the
ttonev/tree-fix-ssr-20.x
branch
from
99ed9cd to
197ef39
Compare
MayaKirova
requested changes
Sep 10, 2025
MayaKirova
requested changes
Sep 18, 2025
| requestAnimationFrame(() => { | ||
| this.selectionService.selectNodesWithNoEvent(toBeSelected); | ||
| }); | ||
| } else { |
Contributor
There was a problem hiding this comment.
The else is still here. It got added back with your last commit.
…I/igniteui-angular into ttonev/tree-fix-ssr-20.x
…I/igniteui-angular into ttonev/tree-fix-ssr-20.x
MayaKirova
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16038
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)